[Host] Refactor 'Retry' delegate in IConsumerErrorHandler as response type #354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the discussed 'pipeline reimagination' was a little too ambitious for the time that I have available; I have refactored the implementation to extract the
retry
delegate fromIConsumerErrorHandler.OnHandleError
and to rather include it as a response value. This does introduce a breaking change, but allows the handler to perform all of the previous logic albeit with a small change for retry.The
OnHandlerError
method signature therefore changes from:to:
In order to retry the execution (with a new scope as requried), the implemented method must return
ConsumerErrorHandlerResult.Retry
. Further to this, abstract implmentations ofIConsumerErrorHandler
have been added with methods to supportFailure()
,Success(object? response = null)
andRetry()
for a cleaner experience (similar toreturn Ok();
with asp.net controllers).Example: