Skip to content

Commit

Permalink
ci_view_test: minimal change TUI chars
Browse files Browse the repository at this point in the history
Due to a minimal change in tview library an additional char was added
when printing the stage and jobs to the terminal. Unfortunately these
tests are too sensitive to this type of changes.

My suggestion is that we remove visual tests from our code, since the
library has their own tests and we should not be worried on how things
are really printed.

Signed-off-by: Bruno Meneguele <[email protected]>
  • Loading branch information
bmeneg committed Apr 18, 2024
1 parent 0dd35f5 commit efa4a47
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions cmd/ci_view_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -422,22 +422,22 @@ func Test_jobsView(t *testing.T) {
" │ Stage1 │ │ Stage2 │ │ Stage3 │ ",
" └────────────────────┘ └────────────────────┘ └────────────────────┘ ",
" ",
" ╔✔ stage1-job1-reall…╗ ┌───● stage2-job1───┐ ┌───● stage3-job1───┐ ",
" ╔✔ stage1-job1-reall…╗ ┌───● stage2-job1───┐ ┌───● stage3-job1───┐ ",
" ║ ║ │ │ │ │ ",
" ║ 01m 01s║━┳━━┳━│ │━┳━━┳━│ │ ",
" ╚════════════════════╝ ┃ ┃ └────────────────────┘ ┃ ┃ └────────────────────┘ ",
" ┃ ┃ ┃ ┃ ",
" ┌───✔ stage1-job2───┐ ┃ ┃ ┌───● stage2-job2───┐ ┃ ┃ ┌───● stage3-job2───┐ ",
" ┌───✔ stage1-job2───┐ ┃ ┃ ┌───● stage2-job2───┐ ┃ ┃ ┌───● stage3-job2───┐ ",
" │ │ ┃ ┃ │ │ ┃ ┃ │ │ ",
" │ │━┫ ┣━│ │━┫ ┗━│ │ ",
" └────────────────────┘ ┃ ┃ └────────────────────┘ ┃ └────────────────────┘ ",
" ┃ ┃ ┃ ",
" ┌───✔ stage1-job3───┐ ┃ ┃ ┌───● stage2-job3───┐ ┃ ",
" ┌───✔ stage1-job3───┐ ┃ ┃ ┌───● stage2-job3───┐ ┃ ",
" │ │ ┃ ┃ │ │ ┃ ",
" │ │━┫ ┗━│ │━┛ ",
" └────────────────────┘ ┃ └────────────────────┘ ",
" ┃ ",
" ┌───✘ stage1-job4───┐ ┃ ",
" ┌───✘ stage1-job4───┐ ┃ ",
" │ │ ┃ ",
" │ │━┛ ",
" └────────────────────┘ ",
Expand Down

0 comments on commit efa4a47

Please sign in to comment.