Cloud 257 Fix Resolving File Paths with a Common Suffix #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Plant <[email protected]>
Signed-off-by: Sam Plant <[email protected]>
Signed-off-by: Sam Plant <[email protected]>
Signed-off-by: Sam Plant <[email protected]>
sampsre
force-pushed
the
CLOUD-257-fix-resolving-file-paths-with-common-suffix
branch
from
3625b7d to
075b62a
Compare
Signed-off-by: Sam Plant <[email protected]>
Signed-off-by: Sam Plant <[email protected]>
adampie
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve workspace directory matching logic
Updates the workspaceForDir method to find the most specific (deepest) matching workspace directory instead of returning the first match. This ensures that nested workspace configurations are handled correctly by comparing path depths.
For example, if we have workspaces configured for both "prod/" and "terraform/prod/", this change will ensure that paths under "terraform/prod/" match the more specific workspace configuration irrelevant of config order.