Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker workflow: execute only if the pr actor is not dependabot or labels contains docker #99

Merged
merged 14 commits into from
Mar 15, 2024
Merged

docker workflow: execute only if the pr actor is not dependabot or labels contains docker #99

merged 14 commits into from
Mar 15, 2024

Conversation

chicco785
Copy link
Member

@chicco785 chicco785 commented Feb 28, 2024 •
edited
Loading

Description

docker workflow: execute only if the pr actor is not dependabot or labels contains docker

Changes Made

  • docker workflow: execute only if the pr actor is not dependabot or labels contains docker
  • markdown and release note workflow: add [dependabot skip] to comment

Related Issues

Fixes #98

Checklist

  • I have used a PR title that is descriptive enough for a release note.
  • I have tested these changes locally.
  • I have added appropriate tests or updated existing tests.
  • I have tested these changes on a dedicated VM or a customer VM [name of the VM]
  • I have added appropriate documentation or updated existing documentation.

@chicco785 chicco785 linked an issue Feb 28, 2024 that may be closed by this pull request
[Feature] Don't run docker workflow for dependabot unless there is a label docker in the PR #98
Closed
@chicco785 chicco785 added dependencies This issue/PR relates to dependencies. docker labels Feb 28, 2024
@chicco785 chicco785 changed the title check if actor is not dependabot and label is not docker docker workflow: execute only if the actor is not dependabot and label is docker (or it's a push) Feb 28, 2024
@chicco785 chicco785 changed the title docker workflow: execute only if the actor is not dependabot and label is docker (or it's a push) docker workflow: execute only if the pr actor is not dependabot and label is docker Feb 28, 2024
@chicco785 chicco785 changed the title docker workflow: execute only if the pr actor is not dependabot and label is docker docker workflow: execute only if the pr actor is not dependabot or labels contains docker Feb 28, 2024
@chicco785 chicco785 marked this pull request as ready for review February 28, 2024 20:36
@chicco785 chicco785 added ci This issue/PR is about continuous integration. feature This issue/PR relates to a feature request. and removed dependencies This issue/PR relates to dependencies. docker ci This issue/PR is about continuous integration. feature This issue/PR relates to a feature request. labels Feb 28, 2024
hiimjako
hiimjako reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@hiimjako hiimjako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me, however, better to have Cosimo's approval

@chicco785 chicco785 enabled auto-merge (squash) March 15, 2024 10:56
@chicco785 chicco785 merged commit 2c89a11 into main Mar 15, 2024
9 checks passed
@chicco785 chicco785 deleted the 98-feature-dont-run-docker-workflow-for-dependabot-unless-there-is-a-label-docker-in-the-pr branch March 15, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiimjako hiimjako hiimjako left review comments

@cosimomeli cosimomeli cosimomeli approved these changes

Assignees

@chicco785 chicco785

Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Don't run docker workflow for dependabot unless there is a label docker in the PR
3 participants
@chicco785 @cosimomeli @hiimjako