Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang workflow: use current branch if base_ref not available #74

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

cosimomeli
Copy link
Contributor

Description

Get the benchmark result artifact from the current branch branch when github.base_ref is emtpy, so if the action is not running in a PR get the previous result from the running branch (usually main)

Changes Made

  • Change the target branch for artifact retrieval from base_ref to base_ref or ref_name

Related Issues

Fixes #73

Checklist

  • I have used a PR title that is descriptive enough for a release note.
  • I have tested these changes locally.
  • I have added appropriate tests or updated existing tests.
  • I have tested these changes on a dedicated VM or a customer VM [name of the VM]
  • I have added appropriate documentation or updated existing documentation.

@cosimomeli cosimomeli added the bug This issue/PR relates to a bug. label Dec 6, 2023
@cosimomeli cosimomeli requested a review from chicco785 December 6, 2023 13:50
@cosimomeli cosimomeli self-assigned this Dec 6, 2023
@chicco785 chicco785 changed the title Use current branch if base_ref not available golang workflow: use current branch if base_ref not available Dec 6, 2023
Copy link
Member

@chicco785 chicco785 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@cosimomeli cosimomeli merged commit ecb60cc into main Dec 6, 2023
8 checks passed
@cosimomeli cosimomeli deleted the 73-fix-benchmark branch December 6, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] It seems that there are some issues with benchmarks on main e.g. for storer
2 participants