Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markdown workflow: fix check to enable/disable spellchecker #55

Merged
merged 6 commits into from
Oct 11, 2023
Merged

markdown workflow: fix check to enable/disable spellchecker #55

merged 6 commits into from
Oct 11, 2023

Conversation

chicco785
Copy link
Member

@chicco785 chicco785 commented Oct 10, 2023 •
edited
Loading

Description

markdown workflow: fix check to enable/disable spellchecker

Changes Made

  • fix check to enable/disable spellchecker
  • add changes check

Related Issues

N/A

Checklist

  • I have used a PR title that is descriptive enough for a release note.
  • I have tested these changes locally.
  • I have added appropriate tests or updated existing tests.
  • I have tested these changes on a dedicated VM or a customer VM [name of the VM]
  • I have added appropriate documentation or updated existing documentation.

@chicco785 chicco785 added the bug This issue/PR relates to a bug. label Oct 10, 2023
@chicco785
fix condition
e15b771 
* fix condition
* check for changes
@chicco785 chicco785 force-pushed the fix-check-spellchecker branch from b85f978 to e15b771 Compare October 10, 2023 14:34
@chicco785 chicco785 changed the title markdown workflow: fix test on usage of spellchecker markdown workflow: fix check to enable/disable spellchecker Oct 10, 2023
@chicco785 chicco785 marked this pull request as ready for review October 10, 2023 14:37
@chicco785 chicco785 requested review from a team October 10, 2023 14:37
hiimjako
hiimjako approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@hiimjako hiimjako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@chicco785 chicco785 merged commit d575bbf into main Oct 11, 2023
7 checks passed
@chicco785 chicco785 deleted the fix-check-spellchecker branch October 11, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiimjako hiimjako hiimjako approved these changes

Assignees

@chicco785 chicco785

Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chicco785 @hiimjako