Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add-to-project workflow: add support to assign multiple teams as reviewers (comma separated without space) #42

Merged
merged 9 commits into from
Oct 10, 2023
Merged

add-to-project workflow: add support to assign multiple teams as reviewers (comma separated without space) #42

merged 9 commits into from
Oct 10, 2023

Conversation

chicco785
Copy link
Member

Description

Add support for assign multiple teams as reviewers (comma separated without space)

Changes Made

  • Split teams using comma and iterate adding rights

Related Issues

Fixes #41

Checklist

  • I have used a PR title that is descriptive enough for a release note.
  • I have tested these changes locally.
  • I have added appropriate tests or updated existing tests.
  • I have tested these changes on a dedicated VM or a customer VM [name of the VM]
  • I have added appropriate documentation or updated existing documentation.

@chicco785 chicco785 linked an issue Oct 3, 2023 that may be closed by this pull request
[Feature] Support review assignment to multiple teams #41
Closed
@chicco785 chicco785 added the feature This issue/PR relates to a feature request. label Oct 3, 2023
@chicco785 chicco785 marked this pull request as ready for review October 3, 2023 12:17
@chicco785 chicco785 requested review from a team and removed request for a team October 3, 2023 12:17
@chicco785 chicco785 marked this pull request as draft October 3, 2023 12:19
@chicco785 chicco785 marked this pull request as ready for review October 3, 2023 12:19
@chicco785 chicco785 requested review from a team and removed request for a team October 3, 2023 12:20
@chicco785 chicco785 marked this pull request as draft October 3, 2023 12:21
@chicco785 chicco785 marked this pull request as ready for review October 3, 2023 12:21
@chicco785 chicco785 requested review from a team October 3, 2023 12:21
@chicco785
* add support for multiple teams comma separated without space
3b6c7a6 
* docs(release_notes): update RELEASE_NOTES.md
@chicco785 chicco785 force-pushed the 41-feature-support-review-assignment-to-multiple-teams branch from f2e4e4b to 3b6c7a6 Compare October 3, 2023 12:23
@chicco785 chicco785 changed the title add support for assign multiple teams as reviewers (comma separated without space) add-to-project workflow: add support for assign multiple teams as reviewers (comma separated without space) Oct 3, 2023
@chicco785 chicco785 mentioned this pull request Oct 3, 2023
Merged
5 tasks
@chicco785 chicco785 changed the title add-to-project workflow: add support for assign multiple teams as reviewers (comma separated without space) add-to-project workflow: add support to assign multiple teams as reviewers (comma separated without space) Oct 3, 2023
@cosimomeli
Copy link
Contributor

This is already in #44 if I'm not wrong

@chicco785
Copy link
Member Author

This is already in #44 if I'm not wrong

indeed, see comment: #44 (comment)

the plan was to merge this one, and rebase the spellchecker one accordingly

@chicco785 chicco785 merged commit ca88f6d into main Oct 10, 2023
6 checks passed
@chicco785 chicco785 deleted the 41-feature-support-review-assignment-to-multiple-teams branch October 10, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosimomeli cosimomeli cosimomeli approved these changes

Assignees

@chicco785 chicco785

Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support review assignment to multiple teams
2 participants
@chicco785 @cosimomeli