Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golang workflow: include .sql and .docker/*.yml files in golang changes filter #142

Merged
merged 3 commits into from
Nov 27, 2024
Merged

golang workflow: include .sql and .docker/*.yml files in golang changes filter #142

merged 3 commits into from
Nov 27, 2024

Conversation

chicco785
Copy link
Member

@chicco785 chicco785 commented Nov 27, 2024 •
edited
Loading

Description

The change of sql files and docker files may impact the behaviour of the applications, so we should run tests when such changes occurs.

Changes Made

  • golang workflow: include sql files in golang changes filter
  • golang workflow: include docker compose files in golang changes filter

Related Issues

N/A

Checklist

  • I have used a PR title that is descriptive enough for a release note.
  • I have tested these changes locally.
  • I have added appropriate tests or updated existing tests.
  • I have tested these changes on a cluster [name of the cluster] / customer [name of the customer]
  • I have added appropriate documentation or updated existing documentation.

@chicco785 chicco785 changed the title golang workflow: include sql and .docker/*.yml files in golang changes filter golang workflow: include .sql and .docker/*.yml files in golang changes filter Nov 27, 2024
@chicco785 chicco785 added the feature This issue/PR relates to a feature request. label Nov 27, 2024
@chicco785 chicco785 requested a review from cosimomeli November 27, 2024 15:27
@chicco785 chicco785 marked this pull request as ready for review November 27, 2024 15:27
@chicco785 chicco785 merged commit 1a82b89 into main Nov 27, 2024
10 checks passed
@chicco785 chicco785 deleted the include-sql-file-changes-in-golang-filter branch November 27, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosimomeli cosimomeli cosimomeli approved these changes

Assignees

@chicco785 chicco785

Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chicco785 @cosimomeli