Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment workflow: fix tag version extraction #137

Merged
merged 2 commits into from
Sep 23, 2024
Merged

deployment workflow: fix tag version extraction #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
241eeb3
Fix tag version extraction in deployment workflow
cosimomeli Sep 23, 2024
24b8e3c
docs(release_notes): update RELEASE_NOTES.md [dependabot skip]
chicco785 Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ jobs:
- name: Get image tag from git tag
if: github.ref_type == 'tag'
run: |
echo "IMAGE_TAG=${$(echo ${{github.ref}} | cut -d'/' -f3)#v}" >> $GITHUB_ENV
tag_version="$(echo ${{github.ref}} | cut -d'/' -f3)"
echo "IMAGE_TAG=${tag_version#v}" >> $GITHUB_ENV
- name: Get image tag from main branch
if: github.ref_type == 'branch' && github.ref == 'refs/heads/main'
run: |
Expand Down
3 changes: 2 additions & 1 deletion RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# GitHub Workflows Release Notes

## 0.0.3-dev - 2024-09-20
## 0.0.3-dev - 2024-09-23

### Features

Expand All @@ -23,6 +23,7 @@

### Bug Fixes

- deployment workflow: fix tag version extraction (PR #137 by @cosimomeli)
- Fix vulnerability-scan typo (PR #133 by @cosimomeli)
- golang workflow: fix changes check (PR #130 by @chicco785)
- Fix deployment workflow on PRs (PR #120 by @cosimomeli)
Expand Down
Loading