Handling possible null (#462)

* Debugging null in unit test * Improving mock to avoid flaky test, attempt 1 * Improving mock to avoid flaky test, attempt 2
zalando · Mar 4, 2018 · feb800d · feb800d
1 parent b08a0c8
commit feb800d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/main/java/de/zalando/ep/zalenium/container/kubernetes/KubernetesContainerClient.java b/src/main/java/de/zalando/ep/zalenium/container/kubernetes/KubernetesContainerClient.java
@@ -323,7 +323,7 @@ public ContainerCreationStatus createContainer(String zaleniumContainerName, Str
 
         // Create the container
         Pod createdPod = doneablePod.done();
-        String containerName = createdPod.getMetadata().getName();
+        String containerName = createdPod.getMetadata() == null ? containerIdPrefix : createdPod.getMetadata().getName();
         return new ContainerCreationStatus(true, containerName, nodePort);
     }
 

diff --git a/src/test/java/de/zalando/ep/zalenium/util/KubernetesContainerMock.java b/src/test/java/de/zalando/ep/zalenium/util/KubernetesContainerMock.java
@@ -61,7 +61,9 @@ public static KubernetesContainerClient getMockedKubernetesContainerClient() {
         Pod zaleniumPod = new PodBuilder()
                 .withNewMetadata()
                 .withLabels(zaleniumPodLabels)
+                .addToLabels(zaleniumPodLabels)
                 .withNamespace("test")
+                .withGenerateName(hostName)
                 .withName(hostName)
                 .and().build();