filters/scheduler: wait for spans finishing in lifo errors test #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| retry := time.NewTicker(100 * time.Millisecond) | ||
| defer retry.Stop() | ||
| for { | ||
| finished := t.MockTracer.FinishedSpans() |
There was a problem hiding this comment.
opentracing/opentracing-go#239 adds UnfinishedSpans() but the library is deprecated opentracing/specification#163 so it seems there will be no new release
|
👍 |
|
I think this fix would fir the upstream well, because the use case is quite generic. I would open an upstream issue, and ask what the maintainers think about it. |
|
noticed the mention of the deprecated state, sorry 😃 |
AlexanderYastrebov
force-pushed
the
fix-lifo-errors-test
branch
from
454df07 to
1e23cb0
Compare
The tests was introduced by #1944 It may happen that not all spans are finished by the time test verifies response results (because spans are closed after response has been served). This change waits for all mock spans to finish and forces scheduler metrics update. Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
fix-lifo-errors-test
branch
from
1e23cb0 to
05437e3
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests was introduced by #1944
It may happen that not all spans are finished by the time test verifies response results (because spans are closed after response has been served).
This change waits for all mock spans to finish and forces scheduler metrics update.
Signed-off-by: Alexander Yastrebov [email protected]