-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement major upgrade result annotations #2727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughcapet
requested review from
sdudoladov,
Jan-M,
FxKu,
jopadi,
hughcapet and
macedigital
as code owners
August 13, 2024 14:59
FxKu
reviewed
Aug 26, 2024
FxKu
reviewed
Aug 26, 2024
FxKu
reviewed
Aug 26, 2024
FxKu
reviewed
Aug 26, 2024
FxKu
reviewed
Aug 26, 2024
hughcapet
reviewed
Aug 28, 2024
hughcapet
reviewed
Aug 28, 2024
Co-authored-by: Polina Bungina <[email protected]>
hughcapet
approved these changes
Aug 28, 2024
FxKu
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent Operator endlessly retrying on failing major version upgrade and also to be able to easily identify and be alerted on unsuccessful automated attempts, we need to implement a set of "Failed upgrade" annotations assigned to postgresql resource manifest.
Postgres-operator should annotate postgresql resource with one of the following values based on the return code of the upgrade script:
Operator should:
running PG version < manifest PG version
butlast-major-upgrade-failure
is setrunning PG version >= manifest PG version
last-major-upgrade-failure
when upgrade is failedlast-major-upgrade-success
when upgrade is successcloses #2685