Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populating crd labels and annotations in logical backup job pod manifest #2456

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

andrejshapal
Copy link

Hello,

Fixing #1834

  1. Making sure InheritedLabels set in operator settings / cluster settings are added to backup job pod manifest.
  2. Making sure InheritedAnnotations set in operator settings / cluster setting are added to backup job pod manifest.

The goal is to see backup job resources in ArgoCD.

@andrejshapal andrejshapal changed the title Populating cluster_labels labels in logical backup job pod manifest Populating crd labels and annotations in logical backup job pod manifest Oct 21, 2023
@FxKu
Copy link
Member

FxKu commented Oct 30, 2023

Thanks @andrejshapal. Could you extend the unit test TestGenerateLogicalBackupJob with an annotations check so we have this addition covered?

@FxKu FxKu added this to the 2.0 milestone Oct 30, 2023
@andrejshapal
Copy link
Author

@FxKu Hello, I have added test.

@andrejshapal
Copy link
Author

Hello,
Not sure what means failed e2e. Locally everything passes:
image

@FxKu
Copy link
Member

FxKu commented Jan 4, 2024

👍

1 similar comment
@idanovinda
Copy link
Member

👍

@FxKu FxKu merged commit 0367a07 into zalando:master Jan 4, 2024
2 of 3 checks passed
@FxKu
Copy link
Member

FxKu commented Jan 4, 2024

Thanks @andrejshapal for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants