address review comment

zak-pawel · Dec 17, 2024 · 2cd8d9f · 2cd8d9f
1 parent 1316fba
commit 2cd8d9f
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 11 deletions.
diff --git a/plugins/inputs/lvm/lvm.go b/plugins/inputs/lvm/lvm.go
@@ -33,10 +33,6 @@ func (*LVM) SampleConfig() string {
 	return sampleConfig
 }
 
-func (*LVM) Init() error {
-	return nil
-}
-
 func (lvm *LVM) Gather(acc telegraf.Accumulator) error {
 	if err := lvm.gatherPhysicalVolumes(acc); err != nil {
 		return err

diff --git a/plugins/inputs/monit/monit_test.go b/plugins/inputs/monit/monit_test.go
@@ -17,8 +17,8 @@ import (
 type transportMock struct {
 }
 
-func (*transportMock) RoundTrip(_ *http.Request) (*http.Response, error) {
-	errorString := "Get http://127.0.0.1:2812/_status?format=xml: " +
+func (*transportMock) RoundTrip(*http.Request) (*http.Response, error) {
+	errorString := "get http://127.0.0.1:2812/_status?format=xml: " +
 		"read tcp 192.168.10.2:55610->127.0.0.1:2812: " +
 		"read: connection reset by peer"
 	return nil, errors.New(errorString)

diff --git a/plugins/inputs/mqtt_consumer/mqtt_consumer_test.go b/plugins/inputs/mqtt_consumer/mqtt_consumer_test.go
@@ -64,15 +64,15 @@ type fakeParser struct{}
 // fakeParser satisfies telegraf.Parser
 var _ telegraf.Parser = &fakeParser{}
 
-func (*fakeParser) Parse(_ []byte) ([]telegraf.Metric, error) {
+func (*fakeParser) Parse([]byte) ([]telegraf.Metric, error) {
 	panic("not implemented")
 }
 
-func (*fakeParser) ParseLine(_ string) (telegraf.Metric, error) {
+func (*fakeParser) ParseLine(string) (telegraf.Metric, error) {
 	panic("not implemented")
 }
 
-func (*fakeParser) SetDefaultTags(_ map[string]string) {
+func (*fakeParser) SetDefaultTags(map[string]string) {
 	panic("not implemented")
 }
 

diff --git a/plugins/inputs/phpfpm/fcgi_test.go b/plugins/inputs/phpfpm/fcgi_test.go
@@ -125,7 +125,7 @@ func (c *writeOnlyConn) Write(p []byte) (int, error) {
 	return len(p), nil
 }
 
-func (*writeOnlyConn) Read(_ []byte) (int, error) {
+func (*writeOnlyConn) Read([]byte) (int, error) {
 	return 0, errors.New("conn is write-only")
 }
 

diff --git a/plugins/inputs/redis/redis_test.go b/plugins/inputs/redis/redis_test.go
@@ -25,7 +25,7 @@ func (*testClient) Info() *redis.StringCmd {
 	return nil
 }
 
-func (*testClient) Do(_ string, _ ...interface{}) (interface{}, error) {
+func (*testClient) Do(string, ...interface{}) (interface{}, error) {
 	return 2, nil
 }