Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve seeder to filter and clean dock names #36

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Improve seeder to filter and clean dock names #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions prisma/seed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,27 @@ function randomColor() {
return '#' + Math.floor(Math.random() * 16777215).toString(16);
}

function cleanStationName(stationName: string): string {
return (
stationName
// normalize all of the code points
.normalize('NFKC')
// I believe that any of these modifiers on dock names can be safely removed
// and the data associated with that dock can be safely merged with the
// original.
.replace('\t', ' ')
.replace('\\t', ' ')
.replace('[temporarily removed]', '')
.replace(/ +/, ' ')
.replace('_old', '')
.replace('_new', '')
.replace('[old]', '')
.replace('[new]', '')
.replace(/_[0-9]/, '')
.trim()
);
}

async function getMostRecentData(): Promise<{
mostRecentMonth: number;
mostRecentYear: number;
Expand Down Expand Up @@ -107,10 +128,10 @@ async function seedDocks(file: string, dateStr: string, length: number) {
?? record.start_lng;

if (
// There are a few different docks that include this string in the data
// that we don't want to include. It's test data and somtimes
// malformed anyway.
// There are a few different substrings we can find in dock names that
// indicate docks that we don't want to include in our dataset
!start_station_name.includes('Lab - NYC')
&& !start_station_name.includes('TEMP')
// Sometimes there are just malformed lines with missing dock names
&& start_station_name !== undefined
&& start_station_name !== ''
Expand All @@ -120,7 +141,7 @@ async function seedDocks(file: string, dateStr: string, length: number) {
&& start_station_latitude !== '0.0'
&& start_station_longitude !== '0.0'
) {
docks[start_station_name.normalize('NFKC')] = {
docks[cleanStationName(start_station_name)] = {
latitude: start_station_latitude,
longitude: start_station_longitude,
};
Expand All @@ -144,6 +165,7 @@ async function seedDocks(file: string, dateStr: string, length: number) {
// that we don't want to include. It's test data and somtimes
// malformed anyway.
!end_station_name.includes('Lab - NYC')
&& !start_station_name.includes('TEMP')
// Sometimes there are just malformed lines with missing dock names
&& end_station_name !== undefined
&& end_station_name !== ''
Expand All @@ -153,7 +175,7 @@ async function seedDocks(file: string, dateStr: string, length: number) {
&& end_station_latitude !== '0.0'
&& end_station_longitude !== '0.0'
) {
docks[end_station_name.normalize('NFKC')] = {
docks[cleanStationName(end_station_name)] = {
latitude: end_station_latitude,
longitude: end_station_longitude,
};
Expand Down
Loading