Skip to content

Commit

Permalink
Rename "dock" to "station" in the user-facing copy
Browse files Browse the repository at this point in the history
Unfortunately there is going to be a lot of cleanup to do in the code to
change the vocabulary, but that can wait. I'm prioritizing getting this
out today during my lunch break. :)
  • Loading branch information
zack committed Jul 17, 2024
1 parent ac94f3b commit 50c1de0
Show file tree
Hide file tree
Showing 5 changed files with 44 additions and 20 deletions.
6 changes: 3 additions & 3 deletions app/DockData.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ export default memo(function DockData() {
renderInput={(p) => (
<TextField
{...p}
label={docksLoading ? 'Loading Docks...' : 'Dock'}
label={docksLoading ? 'Loading Stations...' : 'Station'}
InputProps={{
...p.InputProps,
endAdornment: (
Expand Down Expand Up @@ -221,7 +221,7 @@ export default memo(function DockData() {

{dataIsNotUpToDate && (
<Alert severity='warning' sx={{ mt: 3 }}>
<b>Warning:</b> There is no recent data for this dock. It may have
<b>Warning:</b> There is no recent data for this station. It may have
been moved, removed, renamed, or perhaps destroyed in a{' '}
<a href='https://crashnotaccident.com/'>car crash</a>.
</Alert>
Expand Down Expand Up @@ -252,7 +252,7 @@ export default memo(function DockData() {
>
<Typography>
<>
Select a <Bold>{borough}</Bold> dock to see some data.
Select a <Bold>{borough}</Bold> station to see some data.
</>
</Typography>
</Box>
Expand Down
46 changes: 35 additions & 11 deletions app/FAQ.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,11 @@ export default function FAQ() {

<Typography>
I&apos;m counting each docking and undocking as an individual use. That
means most trips generate two uses, and usually at two different docks.
I consider this the most valuable number because it shows how many times
a dock is providing value to someone in a day/month. If you are looking
for data about trips taken, you will have to find that elsewhere, sorry.
means most trips generate two uses, and usually at two different
stations. I consider this the most valuable number because it shows how
many times a station is providing value to someone in a day/month. If
you are looking for data about trips taken, you will have to find that
elsewhere, sorry.
</Typography>

<Typography
Expand All @@ -89,6 +90,29 @@ export default function FAQ() {
available here.
</Typography>

<Typography
variant='h6'
component='h3'
sx={{ fontFamily: exoFontFamily, marginTop: 2 }}
>
Didn&apos;t this used to be about docks? What are stations?
</Typography>

<Typography>
Citi Bike{' '}
<a href='https://help.citibikenyc.com/hc/en-us/articles/360032104712-What-is-a-station-A-dock-A-kiosk'>
defines
</a>{' '}
a dock as the device that holds an individual bicycle. A station is a
row of docks. I originally was accidentally using the term
&apos;dock&apos; when what I really meant was &apos;station&apos;. A
kind commenter on the{' '}
<a href='https://nyc.streetsblog.org/2024/07/17/wednesdays-headlines-citi-bike-by-the-numbers-edition'>
Streetsblog article
</a>{' '}
pointed out the mistake and I have now fixed it.
</Typography>

<Typography
variant='h6'
component='h3'
Expand All @@ -111,16 +135,16 @@ export default function FAQ() {
component='h3'
sx={{ fontFamily: exoFontFamily, marginTop: 2 }}
>
I think I found a missing dock, or something else looks weird
I think I found a missing station, or something else looks weird
</Typography>

<Typography>
I&apos;ll be blunt: Citi Bike&apos;s data is pretty messy. Sometimes
they move docks and/or change names, which makes the data look kind of
weird, but there&apos;s not really anything I can do about that. I also
sometimes have to drop trips (a tiny fraction of a percent of trips)
because the row is malformed. If you think you&apos;ve found something
really wrong, or you&apos;re just not sure, feel free to{' '}
they move stations and/or change names, which makes the data look kind
of weird, but there&apos;s not really anything I can do about that. I
also sometimes have to drop trips (a tiny fraction of a percent of
trips) because the row is malformed. If you think you&apos;ve found
something really wrong, or you&apos;re just not sure, feel free to{' '}
<a href='https://github.com/zack/citibike/issues/new'>
open an issue on GitHub
</a>{' '}
Expand All @@ -129,7 +153,7 @@ export default function FAQ() {
</Typography>

<Typography sx={{ marginTop: 2 }}>
Oh, and I don&apos;t include docks in New Jersey or Canada.
Oh, and I don&apos;t include stations in New Jersey or Canada.
</Typography>
</Box>
);
Expand Down
8 changes: 4 additions & 4 deletions app/Topline.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export default function Topline({
<>
{dockName && (
<>
The dock at
The station at
<Bold>{` ${dockName} `}</Bold>
in
<Bold>{` ${borough === 'Bronx' ? 'the Bronx' : borough} `}</Bold>
Expand All @@ -119,7 +119,7 @@ export default function Topline({
)}
{communityDistrict && (
<>
Docks in
Stations in
<Bold>{` Community District ${communityDistrict} `}</Bold>
in
<Bold>{` ${borough === 'Bronx' ? 'the Bronx' : borough} `}</Bold>
Expand All @@ -128,7 +128,7 @@ export default function Topline({
)}
{councilDistrict && (
<>
Docks in
Stations in
<Bold>{` Council District ${councilDistrict} `}</Bold>
in
<Bold>{` ${borough === 'Bronx' ? 'the Bronx' : borough} `}</Bold>
Expand All @@ -140,7 +140,7 @@ export default function Topline({
&& !communityDistrict
&& borough && (
<>
Docks in
Stations in
<Bold>{` ${borough === 'Bronx' ? 'the Bronx' : borough} `}</Bold>
have
</>
Expand Down
2 changes: 1 addition & 1 deletion app/ViewPicker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export default memo(function ViewPicker() {
</ToggleButton>

<ToggleButton value='dock' aria-label='dock'>
Dock
Station
</ToggleButton>
</ToggleButtonGroup>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default memo(function Home() {
display: 'flex-item',
}}
>
Citi Bike Dock Data
Citi Bike Station Data
</Typography>

<Box sx={{ display: 'flex-item', mb: 1 }}>
Expand Down

0 comments on commit 50c1de0

Please sign in to comment.