Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/following router #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

danmolloy
Copy link
Contributor

Hi Zach,
Apologies for the delay.

I've done as you asked, and copied you method of resolving the styling issue. I copied the className profileTweets__tab__link, perhaps this is something you'll want to change.

There's just one issue - when the url path is '/following', the home sidebar icon is no longer blue. I can't quite find where you're handling this code, but I assume it's very straightforward to resolve.

I hope this helps, let me know if there's anything else.

You've inspired me to start making my own twitter clone!

Apologies again for the delay.
Best wishes, Dan

@zachan-dev
Copy link
Owner

zachan-dev commented Aug 29, 2021

@danmolloy Wow! I am so glad that I have inspired somebody to explore this area! I'm sure you will learn a lot by doing this.

No worries about the 'delay' --- though I don't think there's any delay. I will not be dealing with the project till mid-Sep coz I have university examinations soon. Meanwhile, I will be more than happy if you are willing to help me improve or add other features to this project. You may suggest ideas and implement them using the current framework I built. I am sure that your resume looks stunning by participating in developing this project!

Thank you again for your solution. Your work always teaches me something I didn't know. About the issue u mentioned, yes I encountered it before, there is a hard way to solve as we are using React Router v6, which deleted the easier way back in v5. But I will try to solve it, if not, I will leave it.

I will try the solution before I merge your code. Thanks again for your contribution!

@danmolloy
Copy link
Contributor Author

Hi @zachan-dev, after many months of work I have a functional Twitter clone. Thank you for your encouragement - I visited your code a few times to see how you overcame some issues.
If you're interested I would be very happy to work on other projects together. Dan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants