This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
chore: change depends status from pending to failure #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @johncardiologs thanks for the change. I'm okay with that change but this action worked differently for years. It's not great to change that out of a sudden. Could you instead put this behavior behind a new optional configuration? so that the default behavior remains unchanged. |
|
Would also love to see this get merged in, happy to help if additional work or testing needed. |
|
@z0al lets get this merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the status of the blocked PR status from pending to failure when a PR is marked as dependent.
Motivation
This is an opinionated change, but I find that the orange pending status is not as appropriate as a failure notifier, in the merge status box. I find that most CI tools (e.g. jenkins) will mark the PR with the red failure notifier if the PR should not be merged. The orange pending notifier is usually reserved to ongoing CI runs and suggests that we don't yet know the outcome of the merge status.
Not particularly attached, just a suggestion!