fix(baremetal): debug info for task queue

yunionio · Dec 2, 2024 · 2646335 · 2646335
1 parent 2857dca
commit 2646335
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/pkg/baremetal/manager.go b/pkg/baremetal/manager.go
@@ -1311,8 +1311,10 @@ func (b *SBaremetalInstance) GetTask() tasks.ITask {
 func (b *SBaremetalInstance) SetTask(task tasks.ITask) {
 	b.taskQueue.AppendTask(task)
 	if reflect.DeepEqual(task, b.taskQueue.GetTask()) {
-		log.Infof("Set task equal, ExecuteTask %s", task.GetName())
+		log.Infof("[Baremetal %s] Set task equal, ExecuteTask %s", b.GetId(), task.GetName())
 		tasks.ExecuteTask(task, nil)
+	} else {
+		log.Warningf("[Baremetal %s] task queue is not empty: %s", b.GetId(), b.taskQueue.String())
 	}
 }
 

diff --git a/pkg/baremetal/tasks/base.go b/pkg/baremetal/tasks/base.go
@@ -80,11 +80,20 @@ func (q *Queue) String() string {
 	return fmt.Sprintf("%v", itemStrings)
 }
 
+type iStringer interface {
+	String() string
+}
+
 func debugString(elem *list.Element) []string {
 	if elem == nil {
 		return nil
 	}
+	val := elem.Value
+	valStr, ok := val.(iStringer)
 	strings := []string{fmt.Sprintf("%v", elem.Value)}
+	if ok {
+		strings[0] = valStr.String()
+	}
 	rest := debugString(elem.Next())
 	if rest != nil {
 		strings = append(strings, rest...)