Flutter Webによるdocsビューワの作成 #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 163e289): https://flutter-mobile-project-template-catalog--pr299-docs-we-nhexnejs.web.app (expires Thu, 08 Aug 2024 08:14:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9ea56735a63d07a7cfe62eb204b0528284c37c23 |
yumemi-team-review-requester
bot
requested review from
a team,
takashi0602 and
morikann
and removed request for
a team
|
手元の環境起因でlabeler, labelsの生成に失敗していて、CI落ちてますが、その他の部分見ていただけたらと思います |
|
Ready for review 🚀 |
|
Cleanupでファイル削除するのを忘れていたので、一度Draftに戻します 🙏 |
|
Draft解除しました |
|
Ready for review 🚀 |
|
@mj-hd
|
blendthink
reviewed
Aug 1, 2024
| @@ -3,6 +3,8 @@ removal_list_on_use_template.txt | |||
|
|
|||
| LICENSE.md | |||
|
|
|||
| apps/website | |||
apps/website/assets/docs
Outdated
Comment on lines
+5
to
+6
| # Webを前提とするプロジェクトなので無効化 | ||
| avoid_web_libraries_in_flutter: false |
Comment on lines
+3
to
+4
| This is a web document viewer. | ||
| You can view the markdown documents in the `docs/` directory by this app. |
.github/workflows/debug.yml
Outdated
# Conflicts: # .github/labeler.yml # .github/labels.yml
blendthink
approved these changes
Aug 1, 2024
|
@blendthink すみません、ご対応ありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
レビュー観点
レビューレベル
レビュー優先度
画像 / 動画
確認したこと
動作確認手順
備考
今後のTODO: