Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden user name #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Hidden user name #2

wants to merge 6 commits into from

Conversation

hatappi
Copy link

@hatappi hatappi commented Mar 7, 2017

Hello.

I am using the same ID for github and slack.

team.json is below.

{
  "@hatappi": "<@hatappi>"
}

When commenting on GitHub, mention my account.
because sender's name is included in notification content.

2017-03-07 20 57 35

I looked for way user name is not notified, but I could not find it.
As a solution, added option to hide user name.

Test Environment

Hubot on Heroku

  • use hidden-user-name=1 parameter

image

  • not use hidden-user-name=1 parameter

image

@hatappi
Copy link
Author

hatappi commented Mar 7, 2017

@yujiosaka
Please check my PR 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants