Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy time #179

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Tidy time #179

wants to merge 6 commits into from

Conversation

archessmn
Copy link
Member

Did things:

  • Bump nextjs to remove deprecation warning
  • Tidied up components folder
  • Updated form related exports with a top level export so related imports are grouped
  • Updated eslint rules and made sure everything is happy with the new rules

Copy link
Member

@markspolakovs markspolakovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only skimmed the files where the diff was only in the imports, as I assume that's all automated and correct. I did have some questions about the organisation though.

lib/searchParams/validate.ts Show resolved Hide resolved
features/positions/index.ts Show resolved Hide resolved
features/calendar/events.ts Outdated Show resolved Hide resolved
components/util/DebugMode.tsx Outdated Show resolved Hide resolved
components/navigation/Breadcrumbs.tsx Outdated Show resolved Hide resolved
app/login/slack/callback/route.ts Outdated Show resolved Hide resolved
@jenkins-ystv
Copy link

jenkins-ystv bot commented Oct 15, 2024

Attempted to deploy a preview of this PR, but ran into an error. See the Jenkins output for details.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 122 out of 136 changed files in this pull request and generated no suggestions.

Files not reviewed (14)
  • .eslintrc.json: Language not supported
  • .prettierrc: Language not supported
  • app/(authenticated)/admin/positions/layout.tsx: Evaluated as low risk
  • app/(authenticated)/_components/Breadcrumbs.tsx: Evaluated as low risk
  • app/(authenticated)/admin/roles/layout.tsx: Evaluated as low risk
  • app/(authenticated)/admin/layout.tsx: Evaluated as low risk
  • app/(authenticated)/admin/page.tsx: Evaluated as low risk
  • app/(authenticated)/admin/positions/form.tsx: Evaluated as low risk
  • app/(authenticated)/admin/roles/RoleCard.tsx: Evaluated as low risk
  • app/(authenticated)/admin/positions/actions.ts: Evaluated as low risk
  • app/(authenticated)/admin/roles/actions.ts: Evaluated as low risk
  • app/(authenticated)/admin/positions/PositionCard.tsx: Evaluated as low risk
  • app/(authenticated)/admin/roles/form.tsx: Evaluated as low risk
  • .storybook/preview.ts: Evaluated as low risk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants