Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Overhaul + Homepage #144

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Navigation Overhaul + Homepage #144

wants to merge 6 commits into from

Conversation

Keeeeeeeen
Copy link
Contributor

@Keeeeeeeen Keeeeeeeen commented Sep 7, 2024

General (o7) Navigational overhaul to allow for more pages at root, as well as some styling and formatting changes for consistency

Homepage/New Navigation Bar:
Screenshot1

Nav Page Highlighting + Permission based Nav buttons with correct colour ordering:
Screenshot2

Mobile Nav View + Unnested Admin Pages:
Screenshot3

User Page with Dark/Light Mode folded into it plus UserMenu moved to Nav bar:
Screenshot4

Not ready for merge yet as there a couple of bugs to iron,as well as adding News functionality etc. (Admin pages are also reliant on #137 ), but would appreciate some opinions on what I have so far

@jenkins-ystv
Copy link

jenkins-ystv bot commented Sep 7, 2024

Deployed a preview of this PR to https://pr-144-internal.dev.ystv.co.uk

@markspolakovs
Copy link
Member

I think the contrast on the navbar between the text and the background needs another look, it seems a bit low to me. This is a bit more nitpicky, but I do wonder if there's too much colour there and it distracts from the main content - perhaps only set the background on the active page?

Also, does the nav bar expand/contract or is it permanently open on desktop? In the latter case I think having both a left nav and (what looks in your screenshots to be) a top nav is slightly wasteful of space.

@Keeeeeeeen
Copy link
Contributor Author

Left Nav can be collapsed on desktop, Top Nav can't, and in terms of wasting space, all the space the Nav takes up now was previously whitespace from how the page was centered (so if anything I'd argue it's less wasteful of space as that space is actually being used now.

Though thinking on it, I am slightly tempted to test out a fully left-aligned Nav and do away with the top bar, though I worry that'd be too jarring of a transition (also top nav would have to stay on mobile to house the burger for collapsing the nav)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants