This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Fix integration with Rack::File #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it backward compatible? |
|
With old versions of Rack? Probably not, but given that this change was made to Rack over a year ago I think it's fair to say that in versions of prax moving forward we're only going to support Rack >= 2.0.0 |
|
The Ruby version of Prax is maintenance only (use the Crystal version). I'd like to avoid introducing a change for Rack 2+ that breaks compatibility with older versions of Rack. We can't use |
Changed intoduced to rack in the commit below broke the way that prax uses Rack::File. This change uses the new API. rack/rack@f244d4 rack/rack@ed0d8c
|
@ysbaddaden how does the most recent version look? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed intoduced to rack in the commit below broke the way that prax
uses Rack::File. This change uses the new API.
rack/rack@f244d4
rack/rack@ed0d8c