-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InCluster support as a CronJob #73
Conversation
Hey @patricktalmeida
|
Also feel free to put your ideas here #69 |
I'll break this into 3 branches as you asked and push them soon. About the Deployment part, yeah a friend of mine suggested me to push those metrics to Prometheus in order to have warnings. I also like that feature, though I focused on the one that I really needed for now. We can discuss this one further. Let me know if you have other comments meanwhile. |
Issue for docker ci #74 |
The general direction is good. I want to add something like this #75 |
Yeah, this PR cover this #75, actually. I'll still split them into 3. |
I liked this tool and wanted to fit one of my use cases, which was to send the output to Slack on a weekly basis.
This PR add a support for
kor
to run as a CronJob inside the cluster and send the output to Slack in 2 ways, either by sending raw text with a Slack webhook, or using htefiles.upload
Slack API to send the output as an attached file which supports formatted and bigger outputs than a webhook.First of all, sorry about the big PR.
Let me know of your thinking on this.
If it satisfies and you want to have it merged, change the DockerHub repository from
patricktoledodea/kor
to one of yours on bothrelease.yml
andvalues.yaml
as I won't be maintaining the image with all updates.