Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve panic error due to redefined flags in kor #125

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

Yuni-sa
Copy link
Contributor

@Yuni-sa Yuni-sa commented Nov 5, 2023

Description:
The issue was causing a panic error when running kor due to redefined flags on root.cmd (lines 58-60). This commit addresses the problem by removing the duplicated flags.

Fixes: #124

@Yuni-sa Yuni-sa changed the title fix: Resolve panic error due to redefined flag in kor fix: Resolve panic error due to redefined flags in kor Nov 5, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a55f44) 50.11% compared to head (6a5e665) 50.11%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   50.11%   50.11%           
=======================================
  Files          19       19           
  Lines        1684     1684           
=======================================
  Hits          844      844           
  Misses        700      700           
  Partials      140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yonahd yonahd merged commit 734a6b6 into yonahd:main Nov 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Panic error because of redefined flags
3 participants