Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge findUnused functions #108

Merged
merged 5 commits into from
Oct 19, 2023
Merged

merge findUnused functions #108

merged 5 commits into from
Oct 19, 2023

Conversation

yonahd
Copy link
Owner

@yonahd yonahd commented Oct 18, 2023

No description provided.

@yonahd yonahd linked an issue Oct 18, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (0210609) 42.82% compared to head (24a2637) 54.90%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #108       +/-   ##
===========================================
+ Coverage   42.82%   54.90%   +12.07%     
===========================================
  Files          17       17               
  Lines        1749     1499      -250     
===========================================
+ Hits          749      823       +74     
+ Misses        898      571      -327     
- Partials      102      105        +3     
Files Coverage Δ
pkg/kor/confimgmaps.go 71.42% <75.00%> (+14.94%) ⬆️
pkg/kor/deployments.go 66.66% <75.00%> (+30.60%) ⬆️
pkg/kor/hpas.go 55.55% <81.81%> (+15.35%) ⬆️
pkg/kor/ingresses.go 69.04% <75.00%> (+18.56%) ⬆️
pkg/kor/pdbs.go 59.64% <81.81%> (+21.18%) ⬆️
pkg/kor/pvc.go 63.79% <81.81%> (+22.02%) ⬆️
pkg/kor/roles.go 65.67% <75.00%> (+21.48%) ⬆️
pkg/kor/secrets.go 75.00% <75.00%> (+15.00%) ⬆️
pkg/kor/serviceaccounts.go 66.37% <75.00%> (+13.78%) ⬆️
pkg/kor/services.go 66.66% <75.00%> (+30.60%) ⬆️
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@luisdavim luisdavim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonahd yonahd merged commit ce0998a into main Oct 19, 2023
1 check passed
@yonahd yonahd changed the title merge functions for configmaps merge findUnused functions Oct 19, 2023
@yonahd yonahd deleted the merge_find_unused_funcs branch October 19, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge GetUnusedDeployments and GetUnusedDeploymentsJSON
3 participants