Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add helm condition to skip secret manifest creation when slack secrets are not provided #101

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

Yuni-sa
Copy link
Contributor

@Yuni-sa Yuni-sa commented Oct 10, 2023

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (28cb572) 42.82% compared to head (02f4d21) 42.82%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   42.82%   42.82%           
=======================================
  Files          17       17           
  Lines        1749     1749           
=======================================
  Hits          749      749           
  Misses        898      898           
  Partials      102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonahd yonahd merged commit 2ef9cca into yonahd:main Oct 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Helm chart creates secrets even when no slack token is given
3 participants