Add blob copy capability #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way that the auth url was being used by AuthorizationService was too restrictive and made too many assumptions about the format of the URL; GitLab, for example, uses a different URL format and does not name the service the same as DockerHub does. These changes add a parameter, 'auth_service_name', which allows custom service names that are not simply the same as the registry's host name (e.g. GitlLab uses 'container_registry'), and also changes the URL so that the 'v2/token' location is not necessarily assumed. *This is necessarily a breaking change for existing consumers and will require a majorversion bump*.
This prevents the access token from being sent by the requests library
Rather than forcing command-line and API consumers to change their code, we keep the old arguments and behavior in, but add a warning, allowing the new behavior to be triggered with new arguments
This puts it in the user's PATH upon package installation
Put errors checking before status checking
This takes advantage of the Registry API's cross-repository mount feature to copy blobs from one repo to another without actually downloading and reuploading them. Unit test included.
|
Hello @graingert, this is the PR for the feature I described in the last one: cross-repositiory blob mounting. Please let me know if it requires any changes. Thanks! |
This method checks for the existence of a manifest without downloading it by sending a HEAD request rather than a GET request to the manifest endpoint
This allows consumers to calculate their own digests and put a tag to its digest location, without changing the tag
|
Hello. Since this package appears to be abandoned, I forked it and made several improvements. This includes dropping support for v1 registries, and introducing first-class support for v2 manifests (incluidng multi-arch manifests). If you're still feeling up to it, I'd be happy to review an updated PR against my fork: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to be merged in after #53.
This PR adds a method to the V2 BaseClient:
copy_blob. The method takes advantage of the Registry API's cross-repository blob mount feature to copy blobs that already exist in the registry from one repo to another without actually downloading and re-uploading them.A unit test is included.
Other minor changes in this PR:
check_manifestmethod to test for the existence of a manifestput_manifest(Root cause was a Docker Registry config issue in testing)put_manifest: now consumers can put manifests using their digest as a reference without updating the tag to be the same as the digest (which was the former, erroneous behavior)manifest.digest) to enable users to PUT manifests by digest.