Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make safepoint id a u64 rather than an Operand. #193

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

ptersilie
Copy link

@ptersilie ptersilie commented Aug 13, 2024

Small QOL improvement. See yk PR: ykjit/yk#1371

@ltratt
Copy link

ltratt commented Aug 13, 2024

There are some entertainingly unnecessary brackets in the if condition, but they were there originally, so don't need changing here. LGTM overall.

@vext01
Copy link

vext01 commented Aug 13, 2024

First commit needs rebasing away?

@ptersilie
Copy link
Author

Yes requires a rebase once #192 is in.

@ltratt
Copy link

ltratt commented Aug 13, 2024

@ptersilie I think you can rebase this against master now as the first and second commits are unrelated. Please force push.

@ptersilie
Copy link
Author

Rebased.

@ltratt ltratt added this pull request to the merge queue Aug 13, 2024
Merged via the queue into ykjit:main with commit 10f398c Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants