Serialise llvm.experimental.stackmap as new opcode #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vext01
reviewed
Apr 26, 2024
vext01
reviewed
Apr 26, 2024
| serialiseOpcode(OpCodeDeoptSafepoint); | ||
| // stackmap ID: | ||
| serialiseOperand(I, VLMap, I->getOperand(0)); | ||
|
|
There was a problem hiding this comment.
Maybe I'd remove the newlines between the fields you are serialising, but I won't die on that hill.
vext01
reviewed
Apr 26, 2024
|
Pushed a fix and formatted. Ready to squash (it will need rebasing as there are now merge conflicts with main) |
|
Please squash. |
jacob-hughes
force-pushed
the
serialise_deopt_opcode
branch
from
0c0065c to
4c5e249
Compare
|
Squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.