Avoid assertion failure when serialising constant integer values. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used a loop to get the individual bytes of a constant value and serialise them. This would crash if we ask for 8-bits from the value, but there are fewer than 8 bits to fetch. E.g. for a i1, you can never fetch a whole byte's worth of bits. This change ensures we fetch the right number of bits (i.e. fewer than 8 if there are fewer than 8 left).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used a loop to get the individual bytes of a constant value and serialise them.
This would crash if we ask for 8-bits from the value, but there are fewer than 8 bits to fetch. E.g. for a i1, you can never fetch a whole byte's worth of bits.
This change ensures we fetch the right number of bits (i.e. fewer than 8 if there are fewer than 8 left).
Test for this in ykjit/yk#1107