Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yk assumes all pointers are the same size as a void pointer. #118

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

vext01
Copy link

@vext01 vext01 commented Feb 26, 2024

I think this addresses this comment?

I wasn't sure whether to use sizeof(uintptr_t) or sizeof(void *). Are they the same?

(untested btw :) )

@ltratt
Copy link

ltratt commented Feb 26, 2024

I haven't looked at the latest standard but previously sizeof(void *) and sizeof(uintptr_t) didn't have to be the same. Since we're looking at pointers I'd err on the side of caution, and clarity, and use sizeof(void *).

@vext01
Copy link
Author

vext01 commented Feb 26, 2024

Fixed in 663d66ea740d, OK to squash?

@ltratt
Copy link

ltratt commented Feb 26, 2024

Please squash.

@vext01 vext01 changed the title Yk assumes all pointers are the same size as usize. Yk assumes all pointers are the same size as a void pointer. Feb 26, 2024
@vext01
Copy link
Author

vext01 commented Feb 26, 2024

Squashed and updated commit message.

@ltratt ltratt added this pull request to the merge queue Feb 26, 2024
Merged via the queue into ykjit:main with commit a136c83 Feb 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants