-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PtrToInt. #1163
Implement PtrToInt. #1163
Conversation
@@ -40,5 +43,8 @@ binops: | |||
%5 = fadd nnan float %flt, %flt | |||
%6 = udiv exact i32 %num, 1 | |||
%7 = add <4 x i32> %vecnums, %vecnums | |||
br label %casts | |||
casts: | |||
%8 = ptrtoint ptr %ptr to i8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to add one more here for vectors.
Note that due to the order of our ykllvm merges, #1164 will have to go in before this PR. There will be conflicts. Sorry. |
It might only be the ykllvm submodule update that conflicts? |
We both changed the "unsupported" ll test. If there isn't a conflict, Lukas will have to rename his LLVM IR variable numbers so they are sequential again :) |
Here's the vector case. Will do the rebase once the other PRs are in. |
Can I squash and rebase? |
Go ahead. |
Managed to get out of merge conflict hell. Let's try again. |
|
Ok to squash? |
go ahead. |
Since we cast them to zeroextend instructions, we only have to adjust some debug_asserts to make this work.
Done. |
Since we cast them to zeroextend instructions, we only have to adjust some debug_asserts to make this work.
Requires: ykjit/ykllvm#158