Remove deprecated ExchangeSource::request(maxBytes) API (facebookincu…

…bator#8727) Summary: Pull Request resolved: facebookincubator#8727 Reviewed By: Yuhta Differential Revision: D53662612 fbshipit-source-id: c7f6b1e1a2dc9bb26d1db58afb5bf0a69037333c
yingsu00 · Feb 12, 2024 · f5aa4e9 · f5aa4e9
1 parent 7b68a82
commit f5aa4e9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/velox/common/base/RuntimeMetrics.cpp b/velox/common/base/RuntimeMetrics.cpp
@@ -41,7 +41,8 @@ void RuntimeMetric::merge(const RuntimeMetric& other)
 #endif
 #endif
 {
-  VELOX_CHECK_EQ(unit, other.unit);
+  VELOX_CHECK(unit == other.unit);
+
   sum += other.sum;
   count += other.count;
   min = std::min(min, other.min);

diff --git a/velox/exec/ExchangeSource.h b/velox/exec/ExchangeSource.h
@@ -59,14 +59,6 @@ class ExchangeSource : public std::enable_shared_from_this<ExchangeSource> {
     return requestPending_;
   }
 
-  /// Requests the producer to generate up to 'maxBytes' more data.
-  /// Returns a future that completes when producer responds either with 'data'
-  /// or with a message indicating that all data has been already produced or
-  /// data will take more time to produce.
-  virtual ContinueFuture request(uint32_t /*maxBytes*/) {
-    VELOX_NYI();
-  }
-
   struct Response {
     /// Size of the response in bytes. Zero means response didn't contain any
     /// data.