Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SplObjectStorage instead of array #279

Closed
wants to merge 4 commits into from
Closed

Use SplObjectStorage instead of array #279

wants to merge 4 commits into from

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Sep 8, 2024

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌

Could be benchmarked also

@samdark
Copy link
Member

samdark commented Sep 9, 2024

Could be benchmarked also

Should be benchmarked for both timings and memory consumption.

@samdark samdark self-requested a review September 18, 2024 11:39
@samdark samdark self-assigned this Sep 18, 2024
@samdark
Copy link
Member

samdark commented Sep 20, 2024

Briefly tested by running unit tests.

Current master

  • Time: 00:02.444, Memory: 18.00 MB
  • Time: 00:02.391, Memory: 18.00 MB
  • Time: 00:02.397, Memory: 18.00 MB

This pull request

  • Time: 00:02.483, Memory: 20.00 MB
  • Time: 00:03.047, Memory: 20.00 MB
  • Time: 00:02.370, Memory: 20.00 MB

@samdark
Copy link
Member

samdark commented Sep 20, 2024

So nearly the same performance but more memory consumption.

@samdark samdark closed this Sep 23, 2024
@samdark samdark deleted the object-storage branch September 23, 2024 19:04
@samdark
Copy link
Member

samdark commented Sep 23, 2024

I see no benefits in merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark Awaiting requested review from samdark

Assignees

@samdark samdark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xepozz @samdark