Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase psalm level to 4 and corresponding changes #242

Merged
merged 3 commits into from
Jan 7, 2024
Merged

Increase psalm level to 4 and corresponding changes #242

merged 3 commits into from
Jan 7, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Jan 7, 2024

Q A
Is bugfix?
New feature?
Breaks BC? ✔️

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d39ffff) 76.08% compared to head (8e008e6) 74.54%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #242      +/-   ##
============================================
- Coverage     76.08%   74.54%   -1.55%     
+ Complexity      585      583       -2     
============================================
  Files            48       48              
  Lines          2024     2023       -1     
============================================
- Hits           1540     1508      -32     
- Misses          484      515      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Jan 7, 2024

PR Summary

  • Composer File version update
    The project dependencies are handled using a tool called Composer. In this PR, the version for a package called vimeo/psalm has been updated. This modification helps in keeping the codebase up-to-date and might bring new features or bug fixes from the package.

  • Attribute Modification in Psalm Configuration
    Psalm is a tool used for static analysis of code. The errorLevel attribute in the configuration file has been adjusted. This change adjusts the strictness of the analysis, possibly making code checks more rigorous ensuring high code quality.

  • Code Adjustment in Command Collector
    Changes were made in how the CommandCollector handles different types of events. This enhancement ensures that the system performs ​correctly, no matter what the event type is.

  • Class and Type Hint Modification
    Updates were made to two classes, FilesystemStreamProxy and HttpStreamProxy. The classes were marked as final (meaning that they cannot be subclassed), and the data type for the decorated property was changed. These updates bring certainty about the behaviors of these classes, facilitating safer code.

  • Function check removal in Request Collector
    An object type verification in the collect function of RequestCollector.php was removed. This update may make the function operate more efficiently and might have decreased code redundancy.

  • Annotation Addition in Stream Wrapper
    An instruction (annotation) was added to a condition in the StreamWrapper, indicating that the condition redundancy warning should be ignored by Psalm tool. This annotation serves as a pointer to intentionally left redundancy, possibly in order to handle specific situations.

@vjik vjik requested a review from a team January 7, 2024 12:12
@vjik vjik added the status:code review The pull request needs review. label Jan 7, 2024
@vjik vjik merged commit 2dde067 into master Jan 7, 2024
18 of 19 checks passed
@vjik vjik deleted the psalm4 branch January 7, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants