Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Dumper #231

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Optimize Dumper #231

merged 4 commits into from
Jan 4, 2024

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Jan 4, 2024

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
  • Deleted doubled object map cache check
  • Deleted doubled encoding/decoding
  • Optimized Dumper internal checks

@xepozz xepozz requested a review from a team January 4, 2024 09:17
@xepozz xepozz added the status:code review The pull request needs review. label Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e61844e) 81.81% compared to head (6e6a755) 81.55%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #231      +/-   ##
============================================
- Coverage     81.81%   81.55%   -0.26%     
- Complexity      576      577       +1     
============================================
  Files            40       40              
  Lines          1782     1784       +2     
============================================
- Hits           1458     1455       -3     
- Misses          324      329       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Jan 4, 2024

PR Summary

  • Enhancements to Dumper.php

    • A new variable was introduced to contain a list of classes not to be included during operations.
    • The class's constructor now arranges this list of excluded classes in the reverse order.
    • Modifications were made to methods that convert objects into JSON format, aligning them with new parameters and conditions.
    • The method responsible for boosting the cache's performance now uses a better method for key generation.
  • Updates in FileStorage.php

    • Aligned the functioning of flush with new changes introduced in the Dumper class.
  • Improvements in testing

    • Changes in DumperTest.php and AbstractStorageTest.php were made to align with the updates in the Dumper class. These include alterations in test methods and data providers.

@samdark samdark requested a review from vjik January 4, 2024 10:14
@samdark samdark merged commit d5232f6 into master Jan 4, 2024
21 of 22 checks passed
@samdark samdark deleted the optimize branch January 4, 2024 10:14
@samdark
Copy link
Member

samdark commented Jan 4, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants