Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strings package #226

Merged
merged 5 commits into from
Oct 8, 2023
Merged

Update strings package #226

merged 5 commits into from
Oct 8, 2023

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Sep 21, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Sep 21, 2023

PR Summary

  • Updated the Dependencies
    The version of a critical dependency, "yiisoft/strings", in our project has been revised to "^2.2" in the composer.json file. This update helps keep our project up to date with the latest features and security patches from this dependency.

  • Optimized Pattern Matching Algorithm
    In the BacktraceIgnoreMatcher.php file, we've improved the pattern matching method. This is done by removing the previous loop structure and introducing a new pattern matching class CombinedRegexp from Yiisoft\Strings. The benefit of this change is that it makes the process of checking pattern matches more efficient.

@xepozz xepozz marked this pull request as ready for review October 4, 2023 04:30
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e16d64d) 73.28% compared to head (3065acb) 73.30%.

❗ Current head 3065acb differs from pull request most recent head 51a0c0e. Consider uploading reports for the commit 51a0c0e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #226      +/-   ##
============================================
+ Coverage     73.28%   73.30%   +0.01%     
+ Complexity      551      550       -1     
============================================
  Files            37       37              
  Lines          1707     1708       +1     
============================================
+ Hits           1251     1252       +1     
  Misses          456      456              
Files Coverage Δ
src/Collector/Stream/FilesystemStreamProxy.php 79.67% <100.00%> (+0.16%) ⬆️
src/Collector/Stream/HttpStreamProxy.php 43.47% <100.00%> (+0.41%) ⬆️
src/Helper/BacktraceIgnoreMatcher.php 90.90% <100.00%> (-0.76%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik added the status:under development Someone is working on a pull request. label Oct 4, 2023
@xepozz xepozz merged commit 7557311 into master Oct 8, 2023
13 of 14 checks passed
@xepozz xepozz deleted the strings-patterns branch October 8, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:under development Someone is working on a pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants