[WIP] Add options to control method failure handling in the Router middleware #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbaturin
commented
Oct 25, 2024
olegbaturin
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
| Fixed issues | #249 |
add factories for the method failure responses
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #250 +/- ##
=======================================
Coverage ? 100.00%
Complexity ? 155
=======================================
Files ? 11
Lines ? 455
Branches ? 0
=======================================
Hits ? 455
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
samdark
requested changes
Oct 26, 2024
| ### Automatic responses | ||
|
|
||
| `Yiisoft\Router\Middleware\Router` middleware responds automatically to: | ||
| - `OPTIONS` requests; |
There was a problem hiding this comment.
I think some examples or explanation are needed, since it is not clear how exactly it responds. It's documented below but I think it could be moved here somehow.
vjik
reviewed
Oct 27, 2024
Comment on lines
+90
to
+92
| : $this->responseFactory | ||
| ->createResponse(Status::NO_CONTENT) | ||
| ->withHeader(Header::ALLOW, implode(', ', $methods)); |
There was a problem hiding this comment.
Extract it to new response factory class and use it by default for optionsResponseFactory.
Comment on lines
+102
to
+104
| : $this->responseFactory | ||
| ->createResponse(Status::METHOD_NOT_ALLOWED) | ||
| ->withHeader(Header::ALLOW, implode(', ', $methods)); |
There was a problem hiding this comment.
Extract it to new response factory class and use it by default for notAllowedResponseFactory.
olegbaturin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.