-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Route
, Group
and MatchingResult
dispatcher independent
#222
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
=============================================
+ Coverage 78.66% 93.84% +15.17%
+ Complexity 188 125 -63
=============================================
Files 13 11 -2
Lines 586 406 -180
=============================================
- Hits 461 381 -80
+ Misses 125 25 -100
☔ View full report in Codecov by Sentry. |
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to invalidate enabledMiddlewares
in functions that updates middlewares
property.
Co-authored-by: Rustam Mamadaminov <[email protected]>
Co-authored-by: Rustam Mamadaminov <[email protected]>
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a line that can be covered.
Extracted from #196