-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameters name binding #352
Open
xepozz
wants to merge
6
commits into
master
Choose a base branch
from
parameters-name-binding
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
309100b
Support parameters name binding
xepozz 2729552
Use temp branch
xepozz c0b1c00
Add tests
xepozz ef751dc
Merge branch 'master' into parameters-name-binding
xepozz 30f2521
Add docs
xepozz 6f397c5
Merge branch 'master' into parameters-name-binding
xepozz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -341,6 +341,41 @@ $config = ContainerConfig::create() | |||||
$container = new Container($config); | ||||||
``` | ||||||
|
||||||
## Name binding | ||||||
|
||||||
Name binding is a way to bind a name to a definition. It is used to resolve a definition not by its class name but by a name. | ||||||
|
||||||
Set a definitions with a specific name. It may be typed or untyped reference like: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
1. `'$serviceName' => $definition` | ||||||
2. `Service::class . ' $serviceName' => $definition` | ||||||
|
||||||
```php | ||||||
return [ | ||||||
'$fileCache' => FileCache::class, // implements CacheInterface | ||||||
'$redisCache' => RedisCache::class, // implements CacheInterface | ||||||
CacheInterface::class . ' $memCache' => MemCache::class, // also implements CacheInterface | ||||||
] | ||||||
``` | ||||||
|
||||||
So now you can resolve a definition by its name: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
```php | ||||||
class MyService | ||||||
{ | ||||||
public function __construct( | ||||||
CacheInterface $memCache, // typed reference | ||||||
$fileCache, // untyped reference | ||||||
CacheInterface $redisCache, // typed reference to untyped definition | ||||||
) { | ||||||
// ... | ||||||
} | ||||||
} | ||||||
``` | ||||||
|
||||||
```php | ||||||
$container->get(MyService::class); // returns an instance of MyService | ||||||
``` | ||||||
|
||||||
## Resetting services state | ||||||
|
||||||
Despite stateful services isn't a great practice, these are often inevitable. When you build long-running | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Yiisoft\Di\Tests\Support; | ||
|
||
final class ArgumentNameBinding | ||
{ | ||
public function __construct( | ||
public EngineInterface $markOne, | ||
public EngineInterface $markTwo, | ||
) { | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameter name? Just a "name" is vague in this context.