Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix after update db package #236

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix after update db package #236

merged 2 commits into from
Nov 21, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 19, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 19, 2023

PR Summary

  • Modification in batchInsert method
    The batchInsert method in the source code MigrationBuilder.php has been changed to accept a type called iterable for the rows parameter. This means that the data doesn't necessarily need to be an array, it can accept any form of iterable data structures.

  • Changes to upsert method
    In the same file, MigrationBuilder.php, the upsert method now accepts an array or QueryInterface instead of array or Query for the insertColumns parameter. This simply means it allows for a broader range of input for the insertColumns parameter in your requests.

  • Update in update method
    The update method has had a change where its condition parameter can now accept either an array or a string, where earlier it only accepted an array.

  • Enhancement in createIndex method
    The createIndex method has been upgraded to accept a QueryInterface or string for the subQuery parameter instead of just a QueryInterface. This adjustment enables the provision for a more convenient way to create indexes by accepting either direct 'string' queries or the QueryInterface.

  • Refactoring testExecuteExtended Test
    In the test file AbstractUpdateCommandTest.php, the test case testExecuteExtended was modified. Earlier, there was a conditional check based on the database driver. Now, that's been removed and the test for the column type of dateofbirth always expects a 'date'. This might lead to more uniformity in test execution and results.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9bfbf0) 100.00% compared to head (a424d69) 100.00%.

❗ Current head a424d69 differs from pull request most recent head d54a75f. Consider uploading reports for the commit d54a75f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #236   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       309       309           
===========================================
  Files             19        19           
  Lines           1014      1014           
===========================================
  Hits            1014      1014           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 3f5244c into master Nov 21, 2023
73 of 74 checks passed
@Tigrov Tigrov deleted the fix-after-update-db branch November 21, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant