Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eSeries () #5

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

eSeries () #5

wants to merge 9 commits into from

Conversation

cloudly
Copy link

@cloudly cloudly commented May 4, 2015

总之现在可以这么干了... 貌似没有export成功 :(
echart(xxx) %>% eSeries ( barCategoryGap = 0)

Liyun Chen added 9 commits April 29, 2015 22:44
…rameters in data_bar() because of this so there should be a better way to handle these parameters. Any idea?
Merge branch 'master' of https://github.com/cloudly/recharts-1

Conflicts:
	R/data.R
	R/echart.R
2. simple functions for add line and points to plot. Not tested yet.
3. start to wrap an eSeries function to add Series attributes.
+ add line and add points
@yihui
Copy link
Owner

yihui commented May 4, 2015

谢谢,好大一只PR,我估计我明天才能有时间看。

@cloudly
Copy link
Author

cloudly commented May 4, 2015

嗯,攒了好几天的,调试了一下才敢扔上来 :P

下面我打算要么去写饼图什么,要么就是把itemstyle的参数弄进去。现在这种 echart(xxxx) %>% eSeries ()
之类的至少看起来优雅多了 :P

On Mon, May 4, 2015 at 1:55 PM, Yihui Xie [email protected] wrote:

谢谢,好大一只PR,我估计我明天才能有时间看。


Reply to this email directly or view it on GitHub
#5 (comment).

Find me at www.cloudlychen.net

Senior Analyst, Experimentation Research, eBay.
2065 Hamilton Ave, San Jose, CA, 95125

@cloudly
Copy link
Author

cloudly commented May 4, 2015

此外,double axis的那些我在纠结是不是就不要提供给用户了.....给个饼图已经是我的tolerance 极限了。

2015-05-04 13:57 GMT-07:00 Liyun Chen [email protected]:

嗯,攒了好几天的,调试了一下才敢扔上来 :P

下面我打算要么去写饼图什么,要么就是把itemstyle的参数弄进去。现在这种 echart(xxxx) %>% eSeries ()
之类的至少看起来优雅多了 :P

On Mon, May 4, 2015 at 1:55 PM, Yihui Xie [email protected]
wrote:

谢谢,好大一只PR,我估计我明天才能有时间看。


Reply to this email directly or view it on GitHub
#5 (comment).

Find me at www.cloudlychen.net

Senior Analyst, Experimentation Research, eBay.
2065 Hamilton Ave, San Jose, CA, 95125

Find me at www.cloudlychen.net

Senior Analyst, Experimentation Research, eBay.
2065 Hamilton Ave, San Jose, CA, 95125

@yihui
Copy link
Owner

yihui commented May 6, 2015

呃,今天还是没时间。继续等明日……

又及:双坐标轴和饼图都有其缺陷,但不意味着我们一定不能提供,用户可以选择用不用,那是他们自己的问题了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants