Fix type error message with AtLeastOneUniqueKey class #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsonsmatt
commented
Aug 28, 2024
| @@ -2306,7 +2306,7 @@ mkUniqueKeyInstances mps entDef = do | |||
| typeErrorAtLeastOne :: Q [Dec] | |||
| typeErrorAtLeastOne = do | |||
| let impl = mkImpossible requireUniquesPName | |||
| cxt <- typeErrorMultipleCtx | |||
| cxt <- typeErrorNoneCtx | |||
camkidman
reviewed
Aug 28, 2024
|
|
||
| * [#1544](https://github.com/yesodweb/persistent/pull/1544) | ||
| * Fix type error message when no unique keys are defined on a model and you | ||
| use a function with constraint `AtLeastOneUniqueKey`. |
There was a problem hiding this comment.
FWIW this popped up with another function I was using but it looks to come from the same place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog