Global Unique Index #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvamelichev
requested changes
Sep 25, 2024
| /** | ||
| * Is unique index type | ||
| */ | ||
| boolean unique() default false; |
There was a problem hiding this comment.
Is "unique" an index type or a property of any index that can be created? If it's a dedicated index type, we should use an enum instead, I think.
| } | ||
|
|
||
| private Map<String, Object> buildIndexValues(Schema.Index index, T entity) { | ||
| Map<String, Object> cells = schema.flatten(entity); |
There was a problem hiding this comment.
Strictly speaking, Schema.flatten() is not guaranteed to return a mutable map (but in practice, it does).
I would probably use .entrySet().stream().filter(...).collect(toMap(...)); instead, to filter out fields not belonging to the index (and it would create a new map).
There was a problem hiding this comment.
Maybe new HashMap<>(...); =)? Same result - less code.
There was a problem hiding this comment.
Let's make a new HashMap<>() 👍
nvamelichev
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.