#80: Minimal compatibility: Return YDB SDK's YdbTransaction from YOJ's YdbRepositoryTransaction #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s YdbRepositoryTransaction
g-sg-v
approved these changes
Sep 26, 2024
| * @return YDB SDK {@link YdbTransaction} wrapping this {@code YdbRepositoryTransaction} | ||
| */ | ||
| @ExperimentalApi(issue = "https://github.com/ydb-platform/yoj-project/issues/80") | ||
| public YdbTransaction toSdkTransaction() { |
There was a problem hiding this comment.
As an option: we could add RepositoryTransaction.toNativeTransacton to avoid explicit casting.
Anyway, changes are approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental API: Add minimal compatibility between new YDB SDK's YdbTransaction and YOJ's YdbRepositoryTransaction, accessible inside transaction body via
In the compatibility wrapper, the
getStatusFuture()method always throwsUnsupportedOperationException, and other methods are fully functional (getSessionId()will throw if there is no active YDB session, though.)