Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: FieldValue interface #75

Merged
merged 8 commits into from
Oct 10, 2024
Merged

main: FieldValue interface #75

merged 8 commits into from
Oct 10, 2024

Conversation

lavrukov
Copy link
Contributor

@lavrukov lavrukov commented Jun 1, 2024

No description provided.

@nvamelichev
Copy link
Collaborator

@lavrukov Please fix minor checkstyle failures:

Error:  /home/runner/work/yoj-project/yoj-project/databind/src/main/java/tech/ydb/yoj/databind/expression/values/RealFieldValue.java:13:36: 'switch' is not preceded with whitespace. [WhitespaceAround]
Error:  /home/runner/work/yoj-project/yoj-project/databind/src/main/java/tech/ydb/yoj/databind/expression/values/TimestampFieldValue.java:14:36: 'switch' is not preceded with whitespace. [WhitespaceAround]
Error:  /home/runner/work/yoj-project/yoj-project/databind/src/main/java/tech/ydb/yoj/databind/expression/values/NumberFieldValue.java:14:36: 'switch' is not preceded with whitespace. [WhitespaceAround]
Error:  /home/runner/work/yoj-project/yoj-project/databind/src/main/java/tech/ydb/yoj/databind/expression/values/FieldValue.java:37:1: '{' at column 1 should be on the previous line. [LeftCurly]
Error:  /home/runner/work/yoj-project/yoj-project/databind/src/main/java/tech/ydb/yoj/databind/expression/values/StringFieldValue.java:16:36: 'switch' is not preceded with whitespace. [WhitespaceAround]

and this will be ready to merge, I think :-)

@nvamelichev
Copy link
Collaborator

nvamelichev commented Sep 2, 2024

TODO: Move FieldValue interface a package up (to where it was) for better compatibility

This is impossible due to rules for sealed classes 😢

@nvamelichev
Copy link
Collaborator

UPD: Brought back compatibility FieldValue interface in old package (with deprecation warnings, of course!)

@nvamelichev
Copy link
Collaborator

@lavrukov Sasha, please look at this. I've made the FieldValue interface a bit more backwards-compatible then before, for a smooth transition :-)

(And we'll still release this as the next major version, 2.6.0)

Alexander Lavrukov and others added 8 commits October 4, 2024 22:44
…ll `*FieldValue`s explicitly non-null. Rename: `NumberFieldValue` -> `IntegerFieldValue` to reflect `FieldValueType`'s name 1:1. Fix minor Checkstyle violations.
…st methods. Rename: `BoolFieldValue` -> `BooleanFieldValue` to reflect `FieldValueType`'s name 1:1.
…rearrange IllegalExpressionException subclasses for field value validation errors and make most of them public
@nvamelichev nvamelichev merged commit 981d4de into main Oct 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants