Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enum DbType #28

Merged
merged 8 commits into from
Feb 15, 2024
Merged

enum DbType #28

merged 8 commits into from
Feb 15, 2024

Conversation

lavrukov
Copy link
Contributor

No description provided.

@lavrukov lavrukov changed the title db-type-enum: YdbType enum DbType Feb 15, 2024
@nvamelichev
Copy link
Collaborator

Let's bump version in pom.xml to 2.0.0-SNAPSHOT because we've changed the API incompatibly... and also change JavaField.getDbType() to return DbType enum because we've changed the API :-)

@nvamelichev
Copy link
Collaborator

nvamelichev commented Feb 15, 2024

The tests fail:

[ERROR] Failures: 
[ERROR]   ColumnTest.annotatedFieldDbTypeTest:60 
Expecting ArrayList:
  ["UINT32"]
to contain only:
  ["UInt32"]
element(s) not found:
  ["UInt32"]
and element(s) not expected:
  ["UINT32"]

@lavrukov
Copy link
Contributor Author

The tests fail:

[ERROR] Failures: 
[ERROR]   ColumnTest.annotatedFieldDbTypeTest:60 
Expecting ArrayList:
  ["UINT32"]
to contain only:
  ["UInt32"]
element(s) not found:
  ["UInt32"]
and element(s) not expected:
  ["UINT32"]

done

@nvamelichev
Copy link
Collaborator

Now that we return DbType.DEFAULT instead of "", one fragile test has failed:

[ERROR] tech.ydb.yoj.databind.schema.naming.ColumnTest.plainFieldTypeTest -- Time elapsed: 0.015 s <<< FAILURE!
java.lang.AssertionError: 

Expecting empty but was: [DEFAULT, DEFAULT, DEFAULT]
	at tech.ydb.yoj.databind.schema.naming.ColumnTest.plainFieldTypeTest(ColumnTest.java:52)

Copy link
Collaborator

@nvamelichev nvamelichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nvamelichev nvamelichev merged commit e6e0f43 into main Feb 15, 2024
1 check passed
@nvamelichev nvamelichev deleted the db-type-enum branch February 15, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants