Less usages of schema.getName() #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavrukov
force-pushed
the
less-schema-get-name
branch
3 times, most recently
from
e24954e to
788b772
Compare
lavrukov
force-pushed
the
less-schema-get-name
branch
from
788b772 to
8efc0fc
Compare
nvamelichev
requested changes
Dec 5, 2024
| @@ -136,10 +137,6 @@ public Class<ENTITY> getInSchemaType() { | |||
| return schema.getType(); | |||
| } | |||
|
|
|||
| public @NonNull String getTableName() { | |||
There was a problem hiding this comment.
let's maintain a bit more compatibility by keeping getTableName() and just returning tableDescriptor.tableName() from this method
There was a problem hiding this comment.
You can get this information from TableDescriptor in caller method (or from schema). This method have only one usage in our project, and there is better to fix it. I prefer to make smaller interface and remove this method
| throw new IllegalStateException(String.format("Unable to find index [%s] in table [%s]", | ||
| index, schema.getName())); | ||
| throw new IllegalStateException( | ||
| "Unable to find index [%s] in table [%s]".formatted(index, schema.getTypeName()) |
There was a problem hiding this comment.
let's use: in table [%s] -> for entity [%s] (because we have no access to table descriptor here)
nvamelichev
pushed a commit
that referenced
this pull request
Dec 6, 2024
Co-authored-by: Alexander Lavrukov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.